alamb commented on code in PR #19373: URL: https://github.com/apache/datafusion/pull/19373#discussion_r2630885051
########## datafusion/common/benches/with_hashes.rs: ########## @@ -0,0 +1,209 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Benchmarks for `with_hashes` function + +use ahash::RandomState; +use arrow::array::{ + Array, ArrayRef, ArrowPrimitiveType, DictionaryArray, GenericStringArray, + NullBufferBuilder, OffsetSizeTrait, PrimitiveArray, StringViewArray, make_array, +}; +use arrow::buffer::NullBuffer; +use arrow::datatypes::{ArrowDictionaryKeyType, Int32Type, Int64Type}; +use criterion::{Bencher, Criterion, criterion_group, criterion_main}; +use datafusion_common::hash_utils::with_hashes; +use rand::Rng; +use rand::SeedableRng; +use rand::distr::{Alphanumeric, Distribution, StandardUniform}; +use rand::prelude::StdRng; +use std::sync::Arc; + +const BATCH_SIZE: usize = 8192; + +struct BenchData { + name: &'static str, + array: ArrayRef, +} + +fn criterion_benchmark(c: &mut Criterion) { + let pool = StringPool::new(100, 64); Review Comment: WHile it is randomized, the random number generator uses a fixed seed: ```rust pub fn make_rng() -> StdRng { StdRng::seed_from_u64(42) } ``` So the same strings are used each time. I double checked the strings are the same each run by printing them out to confirm. ```diff diff --git a/datafusion/common/benches/with_hashes.rs b/datafusion/common/benches/with_hashes.rs index 8154c20df..56b970fdc 100644 --- a/datafusion/common/benches/with_hashes.rs +++ b/datafusion/common/benches/with_hashes.rs @@ -41,6 +41,7 @@ struct BenchData { fn criterion_benchmark(c: &mut Criterion) { let pool = StringPool::new(100, 64); + println!("StringPool strings:\n{:#?}", pool.strings); // poll with small strings for string view tests (<=12 bytes are inlined) let small_pool = StringPool::new(100, 5); let cases = [ @@ -139,6 +140,7 @@ pub fn make_rng() -> StdRng { } /// String pool for generating low cardinality data (for dictionaries and string views) +#[derive(Debug)] struct StringPool { strings: Vec<String>, } ``` <details> <summary>Run 1</summary> ``` StringPool strings: [ "hPi3oZCna", "Pi3oZCnaWvL2oIeA07mg3ZtJzh0NoAKhdD", "i3oZCnaWvL2oIeA0", "3oZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ", "oZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM4", "ZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFW", "ZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOW", "CnaWvL2oIeA07mg3ZtJzh0NoAK", "CnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOW", "naW", "aWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTc", "WvL2oIeA07mg3ZtJzh0NoAKhdDq", "vL2oIeA07mg3ZtJzh0NoAKh", "L2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM", "2oIeA07mg3Zt", "oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzO", "IeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZK", "eA07mg3Zt", "A07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWT", "0", "7mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkY", "mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym", "g3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM", "3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZ", "ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCy", "tJzh0NoAKhdDqpQ2dfgaDFWTcI", "Jzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWk", "zh0NoAKhdD", "h0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCy", "0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM47", "NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym4c", "oAKhdDqpQ2dfga", "AKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkY", "K", "hdDqpQ2dfga", "dDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppz", "DqpQ2dfgaDFWTcIylNhZKp3bM477b3", "qpQ2", "pQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym", "Q2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym", "2dfgaDFWTcIylNhZK", "dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28", "fgaDFWTcIylNhZKp3bM477b3ppzOWk", "gaDFWTcIylNhZKp3bM477b3ppzOWkYYm", "gaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ", "aDFWTcIylNhZKp3bM477b3ppzOWkYYmEG", "DFWTcIylNhZKp3bM477b3ppzOWk", "FWTc", "WTcIyl", "TcIylNhZKp3bM477b3ppzOW", "cIylNhZKp3bM477b3ppz", "IylNhZKp3bM477b3ppzOWkYYmEGbC", "ylNhZKp3b", "lNhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2", "NhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAf", "hZKp3bM477b3pp", "ZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQY", "Kp3bM477b3ppzOWkYYmEGbCym4", "p3bM477b3pp", "3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xy", "bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe7", "M477b3ppzOWkYYmEGbCym4cPB4JQ", "477b3ppzOWkYY", "77b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798Kv", "7b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJio", "b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioH", "3ppzOWkYYmEGbCym4cPB4JQYAfz9", "ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJi", "pzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9", "zOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P", "OWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJ", "WkYYmEGbCym4cPB", "kYYmEGbCym4cPB4JQYAfz9f", "YYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9", "YmEGbCym4cPB4JQYAfz9f28i8", "mEGbCym4cPB4JQYAfz9f28i8x", "EGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe", "GbCym", "bCym4cP", "Cym4cPB4JQYAfz9f28i8xyzk2PYZ", "ym4", "ym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkN", "m4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2", "4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798Kvd", "cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny", "PB4JQYAfz9f28i8xyzk2PYZ4O9P4o", "B4JQYAfz9f28i8xy", "4J", "JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkN", "QYAfz9f28i", "YAfz9f28i8xyzk2PY", "Afz9f28i8xyzk2PYZ4O9P4oTe", "f", "z9f28i8xyzk2PYZ4O9P4oTe798KvdJio", "9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNf", "f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNfucH7zCQf1wj", "28i8xyzk2PYZ4O9P4oTe798KvdJioHjV", "8i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNfucH7zC", "i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNfucH7zCQf1wjUe", "8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2r", ] ``` </details> <details> <summary>Run 2</summary> ``` StringPool strings: [ "hPi3oZCna", "Pi3oZCnaWvL2oIeA07mg3ZtJzh0NoAKhdD", "i3oZCnaWvL2oIeA0", "3oZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ", "oZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM4", "ZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFW", "ZCnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOW", "CnaWvL2oIeA07mg3ZtJzh0NoAK", "CnaWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOW", "naW", "aWvL2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTc", "WvL2oIeA07mg3ZtJzh0NoAKhdDq", "vL2oIeA07mg3ZtJzh0NoAKh", "L2oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM", "2oIeA07mg3Zt", "oIeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzO", "IeA07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZK", "eA07mg3Zt", "A07mg3ZtJzh0NoAKhdDqpQ2dfgaDFWT", "0", "7mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkY", "mg3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym", "g3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM", "3ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZ", "ZtJzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCy", "tJzh0NoAKhdDqpQ2dfgaDFWTcI", "Jzh0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWk", "zh0NoAKhdD", "h0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCy", "0NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM47", "NoAKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym4c", "oAKhdDqpQ2dfga", "AKhdDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkY", "K", "hdDqpQ2dfga", "dDqpQ2dfgaDFWTcIylNhZKp3bM477b3ppz", "DqpQ2dfgaDFWTcIylNhZKp3bM477b3", "qpQ2", "pQ2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym", "Q2dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym", "2dfgaDFWTcIylNhZK", "dfgaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28", "fgaDFWTcIylNhZKp3bM477b3ppzOWk", "gaDFWTcIylNhZKp3bM477b3ppzOWkYYm", "gaDFWTcIylNhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ", "aDFWTcIylNhZKp3bM477b3ppzOWkYYmEG", "DFWTcIylNhZKp3bM477b3ppzOWk", "FWTc", "WTcIyl", "TcIylNhZKp3bM477b3ppzOW", "cIylNhZKp3bM477b3ppz", "IylNhZKp3bM477b3ppzOWkYYmEGbC", "ylNhZKp3b", "lNhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2", "NhZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQYAf", "hZKp3bM477b3pp", "ZKp3bM477b3ppzOWkYYmEGbCym4cPB4JQY", "Kp3bM477b3ppzOWkYYmEGbCym4", "p3bM477b3pp", "3bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xy", "bM477b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe7", "M477b3ppzOWkYYmEGbCym4cPB4JQ", "477b3ppzOWkYY", "77b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798Kv", "7b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJio", "b3ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioH", "3ppzOWkYYmEGbCym4cPB4JQYAfz9", "ppzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJi", "pzOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9", "zOWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P", "OWkYYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJ", "WkYYmEGbCym4cPB", "kYYmEGbCym4cPB4JQYAfz9f", "YYmEGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9", "YmEGbCym4cPB4JQYAfz9f28i8", "mEGbCym4cPB4JQYAfz9f28i8x", "EGbCym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe", "GbCym", "bCym4cP", "Cym4cPB4JQYAfz9f28i8xyzk2PYZ", "ym4", "ym4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkN", "m4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2", "4cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798Kvd", "cPB4JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny", "PB4JQYAfz9f28i8xyzk2PYZ4O9P4o", "B4JQYAfz9f28i8xy", "4J", "JQYAfz9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkN", "QYAfz9f28i", "YAfz9f28i8xyzk2PY", "Afz9f28i8xyzk2PYZ4O9P4oTe", "f", "z9f28i8xyzk2PYZ4O9P4oTe798KvdJio", "9f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNf", "f28i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNfucH7zCQf1wj", "28i8xyzk2PYZ4O9P4oTe798KvdJioHjV", "8i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNfucH7zC", "i8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2rSDte9ny3QkNfucH7zCQf1wjUe", "8xyzk2PYZ4O9P4oTe798KvdJioHjVwPSk2r", ] ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
