mbutrovich commented on code in PR #2902:
URL: https://github.com/apache/datafusion-comet/pull/2902#discussion_r2631701382
##########
spark/src/main/scala/org/apache/comet/testing/FuzzDataGenerator.scala:
##########
@@ -88,6 +89,68 @@ object FuzzDataGenerator {
StructType(fields.toSeq)
}
+ def generateNestedSchema(
+ r: Random,
+ numCols: Int,
+ minDepth: Int,
+ maxDepth: Int,
+ options: SchemaGenOptions): StructType = {
+ assert(numCols > 0)
+ assert(minDepth >= 0)
+ assert(maxDepth >= 0)
+ assert(minDepth <= maxDepth)
+ assert(
+ options.generateArray || options.generateStruct || options.generateMap,
+ "cannot generate nested schema if options do not include generating
complex types")
+
+ val counter = new AtomicLong
Review Comment:
Do we anticipate anything concurrent happening here that we need an
`AtomicLong`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
