andygrove commented on code in PR #2934:
URL: https://github.com/apache/datafusion-comet/pull/2934#discussion_r2632019480
##########
spark/src/main/scala/org/apache/comet/serde/structs.scala:
##########
@@ -167,3 +167,67 @@ object CometStructsToJson extends
CometExpressionSerde[StructsToJson] {
}
}
}
+
+object CometJsonToStructs extends CometExpressionSerde[JsonToStructs] {
+
+ override def getSupportLevel(expr: JsonToStructs): SupportLevel = {
+ // this feature is partially implemented and not comprehensively tested yet
Review Comment:
This is mostly about testing. I mostly only have tests for the happy path so
far i.e. correctly formatted JSON. Spark is very forgiving when parsing JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
