jizezhang commented on issue #19055: URL: https://github.com/apache/datafusion/issues/19055#issuecomment-3673662098
Also, to add a test for this change, I think I need a directory of test files with the same schema, as it looks like the cache is used only when table url is a collection https://github.com/apache/datafusion/blob/d493f3d441aa30e7e83d4ff918e07681f985a966/datafusion/datasource/src/url.rs#L257-L258 but currently there is no such directory of files under `parquet-testing` repo. I tested locally with files from benchmark, but to actually add a unit test, I wonder if I should first add test files in `parquet-testing` repo, or if you have other suggestions. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
