alamb commented on code in PR #19413:
URL: https://github.com/apache/datafusion/pull/19413#discussion_r2635577808
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs:
##########
@@ -507,7 +513,36 @@ impl<B: ByteViewType> GroupColumn for
ByteViewGroupValueBuilder<B> {
rows: &[usize],
equal_to_results: &mut [bool],
) {
- self.vectorized_equal_to_inner(group_indices, array, rows,
equal_to_results);
+ let has_nulls = array.null_count() != 0;
+ let array = array.as_byte_view::<B>();
+ let has_buffers = !array.data_buffers().is_empty();
+ // call specialized version based on nulls and buffers presence
Review Comment:
this is the key optimization -- create specialized versions of the
comparison based on properties of the input array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
