andygrove commented on code in PR #2943:
URL: https://github.com/apache/datafusion-comet/pull/2943#discussion_r2635807313
##########
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##########
@@ -309,18 +317,9 @@ class CometFuzzTestSuite extends CometFuzzTestBase {
val df = spark.read.parquet(filename.toString)
df.createOrReplaceTempView("t1")
-
- def hasTemporalType(t: DataType): Boolean = t match {
- case DataTypes.DateType | DataTypes.TimestampType |
- DataTypes.TimestampNTZType =>
- true
- case t: StructType => t.exists(f =>
hasTemporalType(f.dataType))
- case t: ArrayType => hasTemporalType(t.elementType)
Review Comment:
this was missing a check for `MapType` so I added that and moved the method
to `DataTypeSupport`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
