Dandandan commented on PR #19391: URL: https://github.com/apache/datafusion/pull/19391#issuecomment-3677556131
If anything, it should be a bit slower (because of extra instructions). I wrote a test that shows this method to be better when the resulting hash output is of low quality (only bits on the right side), but normal "random" bits seem to work just fine for the usecase of partitioning. It would be probably even better to avoid using a hash combine method and directly use the hasher on multiple columns 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
