rluvaton opened a new pull request, #19430: URL: https://github.com/apache/datafusion/pull/19430
## Which issue does this PR close? N/A ## Rationale for this change Making DataFusion faster. the `insert_accounted` first find the entry (without increasing the capacity) and if missing insert using `entry().insert()` which search again the entry from what I understand. so avoided using `insert_accounted` and always use `entry` and insert of missing which will prepare for insert if the table doesn't have enough space ## What changes are included in this PR? 1. remove usages of `insert_accounted` on `hashbrown::HashTable` with `entry()` and insert if missing 2. added `allocated_size` to `hashbrown::HashTable` 3. remove `map_size` and calculate it on call to `size` as it is very cheap ## Are these changes tested? Existing tests ## Are there any user-facing changes? added `allocated_size` similar to `allocated_size` for `Vec` that we added. ----- from my local tests, it showed good perf improvements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
