timsaucer commented on PR #19437: URL: https://github.com/apache/datafusion/pull/19437#issuecomment-3681956008
@milenkovicm @adriangb this is a proof of concept of an alternative, which I think is actually fairly clean. Basically the idea is that we have two portions of the proto work. There's one codec that turns bytes into physical expressions, plans, etc and vice versa. There a different codec that turns protobuf messages into physical expressions, plans, etc and vice versa. Here we just have two traits so the user can intersect at either point. Then these traits are used throughout the proto code. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
