alamb commented on code in PR #19443:
URL: https://github.com/apache/datafusion/pull/19443#discussion_r2639977857
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -3225,4 +3226,242 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_in_list_esoteric_types() -> Result<()> {
+ // Test esoteric/less common types to validate the transform and
mapping flow.
+ // These types are reinterpreted to base primitive types (e.g.,
Timestamp -> UInt64,
+ // Interval -> Decimal128, Float16 -> UInt16). We just need to verify
basic
+ // functionality works - no need for comprehensive null handling tests.
+
+ // Helper: simple IN test that expects [Some(true), Some(false)]
+ let test_type = |data_type: DataType,
+ in_array: ArrayRef,
+ list_values: Vec<ScalarValue>|
+ -> Result<()> {
+ let schema = Schema::new(vec![Field::new("a", data_type.clone(),
false)]);
+ let col_a = col("a", &schema)?;
+ let batch = RecordBatch::try_new(Arc::new(schema.clone()),
vec![in_array])?;
+
+ let list = list_values.into_iter().map(lit).collect();
+ in_list!(
+ batch,
+ list,
+ &false,
+ vec![Some(true), Some(false)],
+ col_a,
+ &schema
+ );
+ Ok(())
+ };
+
+ // Timestamp types (all units map to Int64 -> UInt64)
+ test_type(
+ DataType::Timestamp(TimeUnit::Second, None),
+ Arc::new(TimestampSecondArray::from(vec![Some(1000), Some(2000)])),
+ vec![
+ ScalarValue::TimestampSecond(Some(1000), None),
+ ScalarValue::TimestampSecond(Some(1500), None),
+ ],
+ )?;
+
+ test_type(
+ DataType::Timestamp(TimeUnit::Millisecond, None),
+ Arc::new(TimestampMillisecondArray::from(vec![
+ Some(1000000),
+ Some(2000000),
+ ])),
+ vec![
+ ScalarValue::TimestampMillisecond(Some(1000000), None),
+ ScalarValue::TimestampMillisecond(Some(1500000), None),
Review Comment:
I think we should also add at least one test with a non `None` timezone
For example, something like
```rust
ScalarValue::TimestampMillisecond(Some(1500000), "+0:00".into()),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
