coderfender commented on code in PR #2817:
URL: https://github.com/apache/datafusion-comet/pull/2817#discussion_r2642908197
##########
native/spark-expr/src/agg_funcs/avg.rs:
##########
@@ -143,11 +143,22 @@ impl AggregateUDFImpl for Avg {
}
}
-/// An accumulator to compute the average
-#[derive(Debug, Default)]
+#[derive(Debug)]
pub struct AvgAccumulator {
sum: Option<f64>,
count: i64,
+ #[allow(dead_code)]
+ eval_mode: EvalMode,
Review Comment:
Thank you @andygrove . I removed attribute all together given that we are
not using it anywhere to change result to none or throw error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
