coderfender commented on code in PR #2817:
URL: https://github.com/apache/datafusion-comet/pull/2817#discussion_r2644423989
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -151,17 +151,6 @@ object CometCount extends
CometAggregateExpressionSerde[Count] {
object CometAverage extends CometAggregateExpressionSerde[Average] {
- override def getSupportLevel(avg: Average): SupportLevel = {
Review Comment:
Thank you @comphead . We still need to support ANSI mode for Decimal input
(which raises exception of there is an overflow unlike the integer
counterpart). I plan to work on that once this is merged but I can create a doc
PR to update support for ANSI mode (for only integer inputs at the moment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
