adriangb commented on PR #19311: URL: https://github.com/apache/datafusion/pull/19311#issuecomment-3688328081
> > > Don't we have this already at the logical and physical expression layers? > > > > > > @adriangb please correct me if I'm wrong, but since we are accessing SQL ast, we cannot have it at a higher level, especially physical planning. The proposed function won't be used in higher-level layers, but only for planning. > > I think the question is if we already have an optimizer rule to simplify expressions (including evaluating literals), what benefit does this PR bring to do it at the SQL planning level? Yes that was my thought as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
