kosiew commented on code in PR #19221:
URL: https://github.com/apache/datafusion/pull/19221#discussion_r2645866173
##########
datafusion/sql/src/expr/value.rs:
##########
@@ -191,75 +191,79 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
negative: bool,
interval: Interval,
) -> Result<Expr> {
- if interval.leading_precision.is_some() {
- return not_impl_err!(
- "Unsupported Interval Expression with leading_precision {:?}",
- interval.leading_precision
- );
- }
-
- if interval.last_field.is_some() {
- return not_impl_err!(
- "Unsupported Interval Expression with last_field {:?}",
- interval.last_field
- );
- }
+ sql_interval_to_expr_impl(negative, interval)
Review Comment:
If I remember correctly, this was necessary because clippy does not like
self in recursion because recursion did not depend on instance state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
