AlyAbdelmoneim commented on PR #19498:
URL: https://github.com/apache/datafusion/pull/19498#issuecomment-3692009929
@Jefffrey Hey, I opened this PR to validate catalog format, since I didn't
want to have all validations in one PR as you requested. I think it's important
you review that my assumption for the default is correct.
In `datafusion/common/src/format.rs:323`:
`impl Default for CatalogFormat {
fn default() -> Self {
CatalogFormat::CSV
}
}`
This is needed because `Option<CatalogFormat>` requires `CatalogFormat:
Default` for the `ConfigField` implementation, though the actual field default
is `None`. Please confirm if `CSV` is the right default value here.
if this PR is good I will proceede with the other validations.
Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
