cxzl25 commented on PR #19420: URL: https://github.com/apache/datafusion/pull/19420#issuecomment-3692240097
@kosiew Thanks for your comments and code. When implementing this PR, I also considered adding a configuration to ExecutionOptions. The reason for choosing to add an option in BinaryExpr is that different binary_expr_preselection_threshold values can be passed for different BinaryExpr instances. However, I still think adding a configuration in ExecutionOptions is also a good idea. Can we implement both of these things in this PR? > For example you can make it accessible via ExecutionOptions: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
