zhuqi-lucas commented on code in PR #19446:
URL: https://github.com/apache/datafusion/pull/19446#discussion_r2649176030
##########
datafusion/datasource/src/file.rs:
##########
@@ -150,15 +150,46 @@ pub trait FileSource: Send + Sync {
/// Try to create a new FileSource that can produce data in the specified
sort order.
///
+ /// This method attempts to optimize data retrieval to match the requested
ordering.
+ /// It receives both the requested ordering and equivalence properties
that describe
+ /// relationships between expressions (e.g., constant columns, monotonic
functions).
+ ///
+ /// # Parameters
+ /// * `order` - The requested sort ordering
+ /// * `eq_properties` - Equivalence properties that can be used to
determine if a reversed
Review Comment:
Good suggestion @alamb , i added more comments about the eq_properties now
in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
