EmilyMatt commented on code in PR #19494:
URL: https://github.com/apache/datafusion/pull/19494#discussion_r2650628804
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -1198,7 +1198,7 @@ impl GroupedHashAggregateStream {
// instead.
// Spilling to disk and reading back also ensures batch size is
consistent
// rather than potentially having one significantly larger last
batch.
- self.spill()?;
+ self.spill()?; // TODO: use sort_batch_chunked instead
Review Comment:
I don't think so, I initially thought about this but then I saw there's an
immediate spill now, rather than returning an in memory stream, which feels
like a deliberate decision, and I didn't want to add side-effects to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
