ntjohnson1 opened a new pull request, #19549: URL: https://github.com/apache/datafusion/pull/19549
## Which issue does this PR close? - Closes #19548 ## Rationale for this change Explanation in the issue. Motivation coming more concretely from datafusion-python https://github.com/apache/datafusion-python/issues/1305#issuecomment-3649891506 ## What changes are included in this PR? * Adds the test from the issue to highlight expected behavior * Expands drop_columns to coerce things into a fully qualified column to support the range of column varieties * This further adds a helper to extract the table name associated with the dataframe to simplify use of qualified drop columns support * This is potentially the most controversial part. I could see a nicer api being `df.col(<name>)` to match the expr version but then we probably do repeated checks for the underlying table name unless there is some caching somewhere. Maybe that performance impact isn't significant. ## Are these changes tested? Yes some additional tests are provided. ## Are there any user-facing changes? I had to update the `drop_columns(&[])` test since the type can no longer be inferred. I'm not sure if that is representative of any actual use cases though since I expect the more common is a vector that might be empty in which case the type would be specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
