rluvaton commented on code in PR #19494:
URL: https://github.com/apache/datafusion/pull/19494#discussion_r2651162942
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -812,23 +827,34 @@ impl ExternalSorter {
}
}
-/// Estimate how much memory is needed to sort a `RecordBatch`.
+/// Calculate how much memory to reserve for sorting a `RecordBatch` from its
size.
Review Comment:
```suggestion
/// Estimate how much memory is needed to sort a `RecordBatch`.
```
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -812,23 +827,34 @@ impl ExternalSorter {
}
}
-/// Estimate how much memory is needed to sort a `RecordBatch`.
+/// Calculate how much memory to reserve for sorting a `RecordBatch` from its
size.
Review Comment:
```suggestion
/// Estimate how much memory is needed to sort a `RecordBatch`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
