AlyAbdelmoneim commented on code in PR #19515: URL: https://github.com/apache/datafusion/pull/19515#discussion_r2656542127
########## datafusion/common/src/lib.rs: ########## @@ -51,6 +51,7 @@ pub mod instant; pub mod metadata; pub mod nested_struct; mod null_equality; +pub mod parquet_config; Review Comment: oh yes it will get messy specially when we add the rest of the validations. what do you think about adding a new module like `common/src/config_validations`, and move the `parquet_config.rs` and `format.rs` (implemented in #17549 ), and the following validations that are to be added in the following PRs closing #17498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
