Jefffrey commented on code in PR #19552:
URL: https://github.com/apache/datafusion/pull/19552#discussion_r2656722076


##########
benchmarks/README.md:
##########
@@ -240,6 +240,21 @@ Benchmark tpch_mem.json
 └──────────────┴──────────────┴──────────────┴───────────────┘
 ```
 
+## Comparing performance of main and a PR
+
+### TPCDS
+
+Considering you already have TPCDS data locally
+
+```shell
+export DATA_DIR=../../datafusion-benchmarks/tpcds/data/sf1/
+export PR_NUMBER=19464
+gh pr checkout $PR_NUMBER --repo apache/datafusion -b pr-$PR_NUMBER

Review Comment:
   ```suggestion
   git fetch upstream pull/$PR_NUMBER/head:pr-$PR_NUMBER
   ```
   
   If we don't want to require `gh` CLI; this is the command I've been using to 
clone PRs locally



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to