bhanreddy1973 commented on PR #19606: URL: https://github.com/apache/datafusion/pull/19606#issuecomment-3705017374
Hi @Jefffrey, thanks for the review! I read the comment on #19155 but want to make sure I understand correctly. Looking at other Spark functions in datafusion-spark (sha1, like, length, ilike), they all use: let nullable = args.arg_fields.iter().any(|f| f.is_nullable());Should `make_interval` follow this same pattern? My concern was that `make_interval` can return NULL on arithmetic overflow (e.g., `year * 12 + month` overflows), even when inputs are non-null. Should overflow: 1. Make the output always nullable (current implementation) 2. Only make output nullable if inputs are nullable (standard pattern) 3. Depend on a `failOnError` / ANSI mode config? Happy to update the implementation once I understand the expected behavior. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
