viirya opened a new pull request, #19614:
URL: https://github.com/apache/datafusion/pull/19614
Refactored the sort-merge join implementation to improve code organization
by extracting all filter-related logic into a dedicated filter.rs module.
Changes:
- Created new filter.rs module (~576 lines) containing:
- Filter metadata tracking (FilterMetadata struct)
- Deferred filtering decision logic (needs_deferred_filtering)
- Filter mask correction for different join types
(get_corrected_filter_mask)
- Filter application with null-joined row handling
(filter_record_batch_by_join_type)
- Helper functions for filter column extraction and batch filtering
- Updated stream.rs:
- Removed ~450 lines of filter-specific code
- Now delegates to filter module functions
- Simplified main join logic to focus on stream processing
- Updated tests.rs:
- Updated imports to use new filter module
- Changed test code to use FilterMetadata struct
- All 47 sort-merge join tests passing
- Fixed null-joined batch creation for joins with different column counts:
- Correctly handles LEFT/RIGHT/FULL outer joins with asymmetric schemas
- Properly extracts and replaces columns based on join type and batch
organization
- Uses RecordBatchOptions to handle nullable field validation in outer
joins
🤖 Generated with [Claude Code](https://claude.com/claude-code)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
