mzabaluev commented on PR #19496:
URL: https://github.com/apache/datafusion/pull/19496#issuecomment-3710992619
<details>
<summary>Benchmark results against the branch base</summary>
```
nth_value_ignore_nulls/first_value_expanding/0%_nulls
time: [229.32 µs 229.97 µs 230.68 µs]
change: [−4.1052% −3.6770% −3.2233%] (p = 0.00 <
0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low mild
7 (7.00%) high mild
1 (1.00%) high severe
nth_value_ignore_nulls/last_value_expanding/0%_nulls
time: [229.63 µs 230.18 µs 230.78 µs]
change: [−4.1494% −3.7747% −3.3808%] (p = 0.00 <
0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) low mild
8 (8.00%) high mild
nth_value_ignore_nulls/nth_value_10_expanding/0%_nulls
time: [231.01 µs 231.38 µs 231.78 µs]
change: [−3.6131% −3.3527% −3.0648%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe
nth_value_ignore_nulls/nth_value_neg10_expanding/0%_nulls
time: [231.72 µs 232.23 µs 232.83 µs]
change: [−3.2292% −2.9837% −2.7387%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
3 (3.00%) high mild
3 (3.00%) high severe
nth_value_ignore_nulls/first_value_sliding_100/0%_nulls
time: [231.63 µs 231.99 µs 232.41 µs]
change: [−3.1696% −2.9230% −2.6831%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe
nth_value_ignore_nulls/last_value_sliding_100/0%_nulls
time: [231.89 µs 232.27 µs 232.71 µs]
change: [−3.3218% −3.0671% −2.8237%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low severe
1 (1.00%) low mild
5 (5.00%) high mild
nth_value_ignore_nulls/first_value_expanding/30%_nulls
time: [519.53 µs 521.02 µs 522.69 µs]
change: [−98.032% −98.025% −98.018%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
3 (3.00%) high mild
1 (1.00%) high severe
nth_value_ignore_nulls/last_value_expanding/30%_nulls
time: [21.887 ms 21.925 ms 21.970 ms]
change: [−15.961% −15.752% −15.531%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) high mild
5 (5.00%) high severe
nth_value_ignore_nulls/nth_value_10_expanding/30%_nulls
time: [605.66 µs 606.99 µs 608.56 µs]
change: [−97.648% −97.640% −97.632%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low severe
1 (1.00%) low mild
5 (5.00%) high mild
nth_value_ignore_nulls/nth_value_neg10_expanding/30%_nulls
time: [12.734 ms 12.765 ms 12.804 ms]
change: [−50.084% −49.902% −49.690%] (p = 0.00 <
0.05)
Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
10 (10.00%) high mild
5 (5.00%) high severe
nth_value_ignore_nulls/first_value_sliding_100/30%_nulls
time: [459.39 µs 460.95 µs 462.60 µs]
change: [−73.979% −73.883% −73.779%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
Benchmarking nth_value_ignore_nulls/last_value_sliding_100/30%_nulls:
Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 5.5s, enable flat sampling, or reduce sample count to 60.
nth_value_ignore_nulls/last_value_sliding_100/30%_nulls
time: [1.0836 ms 1.0861 ms 1.0889 ms]
change: [−37.896% −37.683% −37.418%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe
nth_value_ignore_nulls/first_value_expanding/50%_nulls
time: [526.57 µs 528.12 µs 529.98 µs]
change: [−96.396% −96.382% −96.369%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
1 (1.00%) high mild
5 (5.00%) high severe
nth_value_ignore_nulls/last_value_expanding/50%_nulls
time: [10.949 ms 10.972 ms 11.000 ms]
change: [−24.558% −24.348% −24.116%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
nth_value_ignore_nulls/nth_value_10_expanding/50%_nulls
time: [622.68 µs 624.14 µs 625.84 µs]
change: [−95.905% −95.890% −95.876%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
nth_value_ignore_nulls/nth_value_neg10_expanding/50%_nulls
time: [8.6783 ms 8.6978 ms 8.7208 ms]
change: [−42.546% −42.387% −42.196%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) low mild
3 (3.00%) high severe
nth_value_ignore_nulls/first_value_sliding_100/50%_nulls
time: [464.08 µs 465.38 µs 466.74 µs]
change: [−66.353% −66.223% −66.101%] (p = 0.00 <
0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) low mild
5 (5.00%) high mild
2 (2.00%) high severe
nth_value_ignore_nulls/last_value_sliding_100/50%_nulls
time: [929.50 µs 931.49 µs 933.57 µs]
change: [−36.937% −36.708% −36.466%] (p = 0.00 <
0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
2 (2.00%) low mild
7 (7.00%) high mild
3 (3.00%) high severe
nth_value_ignore_nulls/first_value_expanding/80%_nulls
time: [526.65 µs 527.57 µs 528.64 µs]
change: [−90.400% −90.362% −90.327%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low severe
3 (3.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe
nth_value_ignore_nulls/last_value_expanding/80%_nulls
time: [3.0262 ms 3.0319 ms 3.0383 ms]
change: [−41.230% −41.085% −40.926%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high severe
nth_value_ignore_nulls/nth_value_10_expanding/80%_nulls
time: [614.14 µs 615.48 µs 616.94 µs]
change: [−88.219% −88.182% −88.145%] (p = 0.00 <
0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) low severe
3 (3.00%) low mild
4 (4.00%) high mild
4 (4.00%) high severe
nth_value_ignore_nulls/nth_value_neg10_expanding/80%_nulls
time: [2.6999 ms 2.7116 ms 2.7247 ms]
change: [−48.929% −48.694% −48.420%] (p = 0.00 <
0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) high mild
12 (12.00%) high severe
nth_value_ignore_nulls/first_value_sliding_100/80%_nulls
time: [467.46 µs 468.83 µs 470.30 µs]
change: [−56.178% −56.001% −55.832%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
nth_value_ignore_nulls/last_value_sliding_100/80%_nulls
time: [708.05 µs 710.02 µs 712.01 µs]
change: [−33.955% −33.664% −33.402%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low severe
4 (4.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe
nth_value_nulls_comparison/first_value/ignore_nulls
time: [530.18 µs 531.19 µs 532.34 µs]
change: [−96.352% −96.344% −96.335%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) low severe
1 (1.00%) low mild
3 (3.00%) high mild
2 (2.00%) high severe
nth_value_nulls_comparison/first_value/respect_nulls
time: [73.979 µs 74.062 µs 74.151 µs]
change: [−1.9098% −1.6540% −1.3922%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
7 (7.00%) high mild
1 (1.00%) high severe
nth_value_nulls_comparison/nth_value_10/ignore_nulls
time: [621.26 µs 622.50 µs 623.92 µs]
change: [−95.832% −95.817% −95.799%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low severe
2 (2.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe
nth_value_nulls_comparison/nth_value_10/respect_nulls
time: [74.362 µs 74.470 µs 74.615 µs]
change: [−1.2308% −0.9994% −0.7589%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) low mild
2 (2.00%) high mild
5 (5.00%) high severe
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
