martin-g commented on code in PR #19635:
URL: https://github.com/apache/datafusion/pull/19635#discussion_r2665248063
##########
datafusion/physical-plan/src/joins/hash_join/stream.rs:
##########
@@ -223,6 +223,12 @@ pub(super) struct HashJoinStream {
/// Uses `BatchCoalescer` from arrow to efficiently combine batches.
/// When batches are already close to target size, they bypass coalescing.
output_buffer: Box<BatchCoalescer>,
+ /// Whether this is a null-aware anti join
+ null_aware: bool,
+ /// Whether the probe side (RIGHT) contains any NULL values in join keys
+ /// Only relevant when null_aware is true.
+ /// For LeftAnti with null-aware semantics, if probe side has NULL, no
rows should be output.
+ probe_side_has_null: bool,
Review Comment:
If `probe_side_has_null` is `true` then the whole result should be empty,
right ?
I have the feeling this does not work fully for `PartitionMode::Partitioned`
- one partition may return empty result but its `probe_side_has_null` will be
ignored for all other partitions and they may return non-empty results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
