mbutrovich commented on code in PR #3020:
URL: https://github.com/apache/datafusion-comet/pull/3020#discussion_r2665301223
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometDatetimeExpressionBenchmark.scala:
##########
@@ -30,47 +30,33 @@ import org.apache.spark.sql.internal.SQLConf
*/
object CometDatetimeExpressionBenchmark extends CometBenchmarkBase {
- def dateTruncExprBenchmark(values: Int, useDictionary: Boolean): Unit = {
+ def dateTruncExprBenchmark(values: Int): Unit = {
withTempPath { dir =>
withTempTable("parquetV1Table") {
prepareTable(
dir,
spark.sql(
s"select cast(timestamp_micros(cast(value/100000 as integer)) as
date) as dt FROM $tbl"))
- Seq("YEAR", "YYYY", "YY", "MON", "MONTH", "MM").foreach { level =>
- val isDictionary = if (useDictionary) "(Dictionary)" else ""
- val name = s"Date Truncate $isDictionary - $level"
+ Seq("YEAR", "MONTH").foreach { level =>
+ val name = s"Date Truncate - $level"
val query = s"select trunc(dt, '$level') from parquetV1Table"
runExpressionBenchmark(name, values, query)
}
}
}
}
- def timestampTruncExprBenchmark(values: Int, useDictionary: Boolean): Unit =
{
Review Comment:
I think there are a lot of tests we could start removing this logic from too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
