andygrove commented on PR #3021: URL: https://github.com/apache/datafusion-comet/pull/3021#issuecomment-3715172135
> Do we have any way in `CometBenchmarkBase` to assert that it actually ran natively? Maybe an assertion on the plan outside of the benchmark loop? I know that's veering into test territory, but I'd like to ensure that the benchmark is measuring what we expect in case we introduce an inadvertent fallback. I have a plan for doing this. https://github.com/apache/datafusion-comet/issues/3019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
