iffyio commented on code in PR #2140:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2140#discussion_r2675422722
##########
src/parser/mod.rs:
##########
@@ -19536,4 +19311,11 @@ mod tests {
assert!(Parser::parse_sql(&GenericDialect, &sql).is_err());
}
}
+
+ #[test]
+ fn test_key_value_options_trailing_semicolon() {
+ let sql = "CREATE USER u1 option1 = 'value1' option2 = 'value2';";
+ let ast = Parser::parse_sql(&GenericDialect, sql);
+ assert!(ast.is_ok());
+ }
Review Comment:
Can we have it as a test case in sqlparser_common.rs? also if the test case
can cover all applicable dialects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
