Jefffrey commented on code in PR #19663:
URL: https://github.com/apache/datafusion/pull/19663#discussion_r2675463412
##########
datafusion/functions/src/datetime/to_timestamp.rs:
##########
@@ -325,6 +327,75 @@ impl_to_timestamp_constructors!(ToTimestampMillisFunc);
impl_to_timestamp_constructors!(ToTimestampMicrosFunc);
impl_to_timestamp_constructors!(ToTimestampNanosFunc);
+fn decimal_to_nanoseconds(value: i128, scale: i8) -> i64 {
+ let nanos_exponent = 9_i16 - scale as i16;
+ let timestamp_nanos = if nanos_exponent >= 0 {
+ value * 10_i128.pow(nanos_exponent as u32)
+ } else {
+ value / 10_i128.pow(nanos_exponent.unsigned_abs() as u32)
+ };
+ timestamp_nanos as i64
+}
+
+fn decimal128_to_timestamp_nanos(
Review Comment:
Perhaps we should just bundle decimal256 with the same path that
decimal32/decimal64 takes; that is we do the cast to decimal128 and only have
conversion code for that path, so we can let the arrow kernel handle those
checks for us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
