Rachelint commented on issue #19649: URL: https://github.com/apache/datafusion/issues/19649#issuecomment-3736938956
> That makes sense [@Rachelint](https://github.com/Rachelint) , given you have already worked on the blocked approach, would you like to raise the new feature first? We can start filing tickets for refactoring in the parallel? [@adriangb](https://github.com/adriangb) [@alamb](https://github.com/alamb) [@2010YOUY01](https://github.com/2010YOUY01) thoughts? Yes, I have reopened and continued to push forward #15591 (the new feature part), actually just a few features are added to aggr path, and #15591 is actually reviewed for a long time before. Maybe we can merge it after I resolved the conflicts today and merge, then start refactoring? And for alternative, if #15591 is too large to review, maybe we just split #15591 into 2 parts for not blocking refactoring: - One mainly for code changes about `GroupedHashAggregateStream` (it is a very small pr less 200 lines code changes) - Another for code changes about `Accumulator` and `GroupValues` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
