comphead commented on code in PR #3065: URL: https://github.com/apache/datafusion-comet/pull/3065#discussion_r2682924284
########## benchmarks/pyspark/run_all_benchmarks.sh: ########## @@ -0,0 +1,118 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Run all shuffle benchmarks (Spark, Comet JVM, Comet Native) +# Check the Spark UI during each run to compare shuffle sizes + +set -e + +SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +DATA_PATH="${1:-/tmp/shuffle-benchmark-data}" +COMET_JAR="${COMET_JAR:-$SCRIPT_DIR/../spark/target/comet-spark-spark3.5_2.12-0.13.0-SNAPSHOT.jar}" +SPARK_MASTER="${SPARK_MASTER:-local[*]}" +EXECUTOR_MEMORY="${EXECUTOR_MEMORY:-16g}" +EVENT_LOG_DIR="${EVENT_LOG_DIR:-/tmp/spark-events}" + +# Create event log directory +mkdir -p "$EVENT_LOG_DIR" + +echo "========================================" +echo "Shuffle Size Comparison Benchmark" +echo "========================================" +echo "Data path: $DATA_PATH" +echo "Comet JAR: $COMET_JAR" +echo "Spark master: $SPARK_MASTER" +echo "Executor memory: $EXECUTOR_MEMORY" +echo "Event log dir: $EVENT_LOG_DIR" +echo "========================================" + +# Run Spark baseline (no Comet) +echo "" +echo ">>> Running SPARK shuffle benchmark..." +$SPARK_HOME/bin/spark-submit \ + --master "$SPARK_MASTER" \ + --executor-memory "$EXECUTOR_MEMORY" \ + --conf spark.eventLog.enabled=true \ + --conf spark.eventLog.dir="$EVENT_LOG_DIR" \ + --conf spark.comet.enabled=false \ + --conf spark.comet.exec.shuffle.enabled=false \ + "$SCRIPT_DIR/run_benchmark.py" \ + --data "$DATA_PATH" \ + --mode spark + +# Run Comet JVM shuffle +echo "" +echo ">>> Running COMET JVM shuffle benchmark..." +$SPARK_HOME/bin/spark-submit \ + --master "$SPARK_MASTER" \ + --executor-memory "$EXECUTOR_MEMORY" \ + --jars "$COMET_JAR" \ + --driver-class-path "$COMET_JAR" \ + --conf spark.executor.extraClassPath="$COMET_JAR" \ + --conf spark.eventLog.enabled=true \ + --conf spark.eventLog.dir="$EVENT_LOG_DIR" \ + --conf spark.memory.offHeap.enabled=true \ + --conf spark.memory.offHeap.size=16g \ + --conf spark.comet.enabled=true \ + --conf spark.comet.exec.enabled=true \ + --conf spark.comet.exec.all.enabled=true \ + --conf spark.comet.exec.shuffle.enabled=true \ + --conf spark.comet.shuffle.mode=jvm \ Review Comment: ```suggestion ``` this is hallucination -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
