alamb commented on code in PR #18542:
URL: https://github.com/apache/datafusion/pull/18542#discussion_r2683265253


##########
ci/scripts/rust_fmt.sh:
##########
@@ -18,4 +18,13 @@
 # under the License.
 
 set -ex
-cargo fmt --all -- --check
+
+# Install nightly toolchain (skips if already installed)
+rustup toolchain install nightly --component rustfmt

Review Comment:
   when I do `rustup update` it removes the existing version of `nightly` and 
replaces it with a new one
   
   For example
   ```shell
   andrewlamb@Andrews-MacBook-Pro-3:~$ rustup update
   ...
     stable-aarch64-apple-darwin unchanged - rustc 1.92.0 (ded5c06cf 2025-12-08)
      nightly-aarch64-apple-darwin updated - rustc 1.94.0-nightly (b68e16cfc 
2026-01-11) (from rustc 1.94.0-nightly (8d670b93d 2025-12-31))
       1.74-aarch64-apple-darwin unchanged - rustc 1.74.1 (a28077b28 2023-12-04)
       1.81-aarch64-apple-darwin unchanged - rustc 1.81.0 (eeb90cda1 2024-09-04)
       1.88-aarch64-apple-darwin unchanged - rustc 1.88.0 (6b00bc388 2025-06-23)
       1.89-aarch64-apple-darwin unchanged - rustc 1.89.0 (29483883e 2025-08-04)
       1.90-aarch64-apple-darwin unchanged - rustc 1.90.0 (1159e78c4 2025-09-14)
       1.91-aarch64-apple-darwin unchanged - rustc 1.91.1 (ed61e7d7e 2025-11-07)
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to