Re: [PR] doc: Add an auto-generated dependency graph for internal crates [datafusion]

Tue, 13 Jan 2026 00:56:03 -0800 


2010YOUY01 commented on PR #19280:
URL: https://github.com/apache/datafusion/pull/19280#issuecomment-3742958601

   > <img alt="Image" width="566" height="242" 
src="https://private-user-images.githubusercontent.com/22608443/534909944-2b1c3916-dc02-4c57-bf4f-3109b0cba3b7.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjgyOTQzMjYsIm5iZiI6MTc2ODI5NDAyNiwicGF0aCI6Ii8yMjYwODQ0My81MzQ5MDk5NDQtMmIxYzM5MTYtZGMwMi00YzU3LWJmNGYtMzEwOWIwY2JhM2I3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTEzVDA4NDcwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxMzkzZjMyYzBkMTI4ZDRlMjVjN2U5NzZkNmNlYTU2MDljNjM5NmI3MTQzM2ZjYTdmMzYzNTA3ZmE1NWFjODcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QzFn--x12er5MQrUDO8RRA9uKuLg49-Y1FeGKJ818-M";>
   > Some of these look a bit odd. I guess it omits direct dependencies if they 
have a transitive dependency? For example, it says `datafusion-examples` 
depends on `datafusion-proto` only but this is not the case 🤔
   
   Yes, otherwise the dep graph would be quite hard to read. I usually use this 
dep graph to decide where to put/move modules, so ignoring transitive 
dependencies won't be an issue.
   I updated the comment below the dep graph to make it clear.
   
   > (minor nit, but I wonder if there's a better way to represent the 
gen/gen-common binaries or just omit them entirely)
   
   I updated the script to ignore it. They're only used in internal scripts do 
I think it's better to omit them.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to