alamb commented on code in PR #19561:
URL: https://github.com/apache/datafusion/pull/19561#discussion_r2686036722
##########
datafusion/datasource-parquet/src/metrics.rs:
##########
@@ -77,11 +77,11 @@ pub struct ParquetFileMetrics {
/// Parquet.
///
/// This is the expensive path (IO + Decompression + Decoding).
- pub predicate_cache_inner_records: Count,
+ pub predicate_cache_inner_records: Gauge,
Review Comment:
It may be somewhat subtle why this is a gauge. Maybe we can add a comment
explaining the context
Something like
```suggestion
///
/// Use a Gauge to avoid double counting inner counter values from
parquet reader
pub predicate_cache_inner_records: Gauge,
```
(also below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
