mbutrovich commented on code in PR #3077: URL: https://github.com/apache/datafusion-comet/pull/3077#discussion_r2688046547
########## spark/src/test/scala/org/apache/comet/CometHashExpressionSuite.scala: ########## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet + +import org.scalactic.source.Position +import org.scalatest.Tag + +import org.apache.spark.sql.CometTestBase +import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper + +/** + * Test suite for Spark murmur3 hash function compatibility between Spark and Comet. + * + * These tests verify that Comet's native implementation of murmur3 hash produces identical + * results to Spark's implementation for all supported data types. + */ +class CometHashExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { Review Comment: Mostly just interested in the fuzz data generation, seems like a good schema to throw at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
