bert-beyondloops commented on code in PR #19785: URL: https://github.com/apache/datafusion/pull/19785#discussion_r2689623728
########## datafusion/sqllogictest/test_files/limit.slt: ########## @@ -872,3 +872,25 @@ DROP TABLE test_limit_with_partitions; # Tear down src_table table: statement ok DROP TABLE src_table; + + + +# tests with target partition set to 1 +statement ok +set datafusion.execution.target_partitions = '1'; Review Comment: I intentionally included the comment: `tests with target partition set to 1` to mark that all subsequent tests use this configuration. I couldn't find a method to reset this setting (I'm unsure what the initial value was, and there's no obvious way to preserve and reapply it?). Looking at other slt files, I noticed that some settings are similarly modified without being reset—see order.slt as an example. If there's a standard approach for handling this, I'd be happy to implement it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
