kosiew commented on code in PR #19674:
URL: https://github.com/apache/datafusion/pull/19674#discussion_r2689199891
##########
datafusion/sqllogictest/test_files/struct.slt:
##########
@@ -553,16 +552,13 @@ Struct("a": Float32, "b": Utf8View)
statement ok
drop table t;
-# row() with incorrect order
+# row() with incorrect order - row() is positional, not name-based
statement error DataFusion error: Optimizer rule 'simplify_expressions'
failed[\s\S]*Arrow error: Cast error: Cannot cast string 'blue' to value of
Float32 type
create table t(a struct(r varchar, c int), b struct(r varchar, c float)) as
values
(row('red', 1), row(2.3, 'blue')),
(row('purple', 1), row('green', 2.3));
-# out of order struct literal
-# TODO: This query should not fail
-statement error DataFusion error: Optimizer rule 'simplify_expressions'
failed[\s\S]*Arrow error: Cast error: Cannot cast string 'b' to value of Int32
type
Review Comment:
Redundant test removed: out-of-order struct literal is covered by casting
tests below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
