Dandandan commented on code in PR #19808:
URL: https://github.com/apache/datafusion/pull/19808#discussion_r2690306922
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -958,6 +966,15 @@ impl ExecutionPlan for HashJoinExec {
Distribution::HashPartitioned(right_expr),
]
}
+ PartitionMode::LazyPartitioned => {
+ // LazyPartitioned mode: build side is NOT repartitioned (we
read all
+ // partitions and filter locally), but probe side IS
hash-partitioned.
+ let right_expr = self.on.iter().map(|(_, r)|
Arc::clone(r)).collect();
Review Comment:
Perhaps it is even better to start with (only avoid repartitioning the probe
side, I meant this originally but put build side in the description):
`vec![ Distribution::Hash(expr), Distribution::UnspecifiedDistribution, ]`
as it probably will be needed any way to redistribute/prepare the left side
and the probe side will be often the larger one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
