lemorage commented on code in PR #19807:
URL: https://github.com/apache/datafusion/pull/19807#discussion_r2692724802
##########
datafusion/functions/src/datetime/date_part.rs:
##########
@@ -349,6 +352,7 @@ fn seconds(array: &dyn Array, unit: TimeUnit) ->
Result<ArrayRef> {
fn epoch(array: &dyn Array) -> Result<ArrayRef> {
const SECONDS_IN_A_DAY: f64 = 86400_f64;
+ const DAYS_PER_MONTH: f64 = 30_f64;
Review Comment:
Yes! I just followed the PostgreSQL-way for simplicity here, what do u think?
>
https://doxygen.postgresql.org/datatype_2timestamp_8h.html#ad35c6d425de4ccc4718c6ce7f4bfbba2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
