Jefffrey commented on PR #19819: URL: https://github.com/apache/datafusion/pull/19819#issuecomment-3752882802
Personally I'm not sure about this approach as it might suggest all other string functions with similar signature should now be fixed to also ensure they coerce from binary 🤔 e.g. https://github.com/apache/datafusion/blob/0808f3a8d2646c9435557db059759653c3f2c383/datafusion/functions/src/string/ascii.rs#L63-L74 https://github.com/apache/datafusion/blob/0808f3a8d2646c9435557db059759653c3f2c383/datafusion/functions/src/string/btrim.rs#L80-L98 https://github.com/apache/datafusion/blob/0808f3a8d2646c9435557db059759653c3f2c383/datafusion/functions/src/string/contains.rs#L59-L71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
