kumarUjjawal commented on code in PR #19788:
URL: https://github.com/apache/datafusion/pull/19788#discussion_r2693762834
##########
datafusion/functions/src/math/trunc.rs:
##########
@@ -110,7 +110,57 @@ impl ScalarUDFImpl for TruncFunc {
}
fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
- make_scalar_function(trunc, vec![])(&args.args)
+ // Extract precision from second argument (default 0)
+ let precision = match args.args.get(1) {
+ Some(ColumnarValue::Scalar(Int64(Some(p)))) => Some(*p),
+ Some(ColumnarValue::Scalar(Int64(None))) => None, // null precision
+ Some(ColumnarValue::Array(_)) => {
+ // Precision is an array - use array path
+ return make_scalar_function(trunc, vec![])(&args.args);
+ }
+ None => Some(0), // default precision
+ _ => Some(0),
Review Comment:
Yes it should. Made changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
