askalt commented on code in PR #19792:
URL: https://github.com/apache/datafusion/pull/19792#discussion_r2694102346
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -277,8 +288,9 @@ impl ExecutionPlan for ProjectionExec {
self: Arc<Self>,
mut children: Vec<Arc<dyn ExecutionPlan>>,
) -> Result<Arc<dyn ExecutionPlan>> {
+ check_if_same_properties!(self, children);
Review Comment:
Fast-path is currently implemented for most plans. It seems quite odd to me
that we need to ensure it's implemented for every plan (if at least one plan
doesn't implement this check and recalculates its properties, then
recalculation will be performed for all parent plans). I've reduced the
required code as much as possible: a plan implementer needs to call the added
macro and implement the `with_new_children_and_same_properties(...)` method for
the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
