martin-g opened a new pull request, #19830:
URL: https://github.com/apache/datafusion/pull/19830

   ## Which issue does this PR close?
   
   - Closes #.
   
   ## Rationale for this change
   
   Replace usages of `str::to_lowercase().as_str()` + patterm matching with 
`str::eq_ignore_ascii_case(&str)` to avoid allocating temporary String.
   
   ## What changes are included in this PR?
   
   It is a boring change from
   ```rust
   match some_str.to_lowercase().as_str() {
    "one" => ...,
    "two" => ...,
    ...
   }
   ```
   to
   ```rust
   if some_str.eq_ignore_ascii_case("one") { 
     ...
   } else if some_str.eq_ignore_ascii_case("two") {
     ...
   } ...
   ```
   
   ## Are these changes tested?
   
   The logic should be already covered by old tests.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to