mbutrovich commented on PR #3140: URL: https://github.com/apache/datafusion-comet/pull/3140#issuecomment-3755324660
Claude helped me summarize the benchmarks above compared to https://github.com/apache/datafusion-comet/pull/3077#issuecomment-3750671628 | Test | PR #3077 | PR #3140 | Improvement | |------|----------|----------|-------------| | hash_array_int | 153ms (145.6 ns/row) | 48-50ms (46.2 ns/row) | **3.1x faster** | | hash_array_string | 177ms (169.0 ns/row) | 94-95ms (89.3 ns/row) | **1.9x faster** | | hash_array_double | 116ms (110.6 ns/row) | 49-50ms (46.9 ns/row) | **2.3x faster** | | hash_struct | 70ms (67.2 ns/row) | 67-68ms (63.6 ns/row) | **1.05x faster** | | hash_struct_with_array | 183ms (174.7 ns/row) | 101-102ms (96.2 ns/row) | **1.8x faster** | I didn't see the win I hoped for in the non-complex-type scenarios. I wonder what I can figure out there, but I'll punt on that for now. We don't have benchmarks for maps so I don't have those numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
