andygrove commented on PR #19829:
URL: https://github.com/apache/datafusion/pull/19829#issuecomment-3756100380
@cht42 could you add tests for DST handling with different time zones? I am
not convinced that the current PR handles this correctly.
Here is an AI-generated test that highlights the issue:
```
# Test with explicit timezone in timestamp
statement ok
SET datafusion.execution.time_zone = 'America/New_York';
# Cross-day boundary: 03:30 UTC on July 15 = 23:30 EDT on July 14
# TODO: Spark returns 2024-07-14 (converts to session tz first)
# DataFusion returns 2024-07-15 (truncates in UTC)
query P
SELECT date_trunc('DAY', '2024-07-15T03:30:00Z'::timestamp);
----
2024-07-15T00:00:00
# Reset timezone for other tests
statement ok
RESET datafusion.execution.time_zone
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
