alamb opened a new pull request, #19835: URL: https://github.com/apache/datafusion/pull/19835
## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/19809 ## Rationale for this change The ClickBench partitioned dataset was written by an ancient version of pyarrow that that wrote strings with the wrong logical type. To read it correctly, we must automatically convert binary to string. This is the configuration we run the ClickBench benchmark in as well: https://github.com/apache/datafusion/blob/cd12d510395eabb7ee51cac0a4cc7c7ffd1ac841/benchmarks/src/clickbench.rs#L184-L183 ## What changes are included in this PR? Change the sql planner benchmark to use the correct setting I tested it manually -- before this change this command fails ```shell cargo bench --profile=dev --bench sql_planner -- q50 ... thread 'main' (38326073) panicked at datafusion/core/benches/sql_planner.rs:62:14: called `Result::unwrap()` on an `Err` value: Context("type_coercion", Internal("Expect TypeSignatureClass::Native(LogicalType(Native(String), String)) but received NativeType::Binary, DataType: BinaryView")) note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` After this change the command passes ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
