comphead commented on code in PR #3076:
URL: https://github.com/apache/datafusion-comet/pull/3076#discussion_r2695954724
##########
docs/source/contributor-guide/jvm_shuffle.md:
##########
@@ -46,12 +46,10 @@ JVM shuffle (`CometColumnarExchange`) is used instead of
native shuffle (`CometE
(not a `CometPlan`), JVM shuffle is the only option since native shuffle
requires columnar input
from Comet operators.
-3. **Unsupported partitioning type**: Native shuffle only supports
`HashPartitioning`, `RangePartitioning`,
- and `SinglePartition`. JVM shuffle additionally supports
`RoundRobinPartitioning`.
-
-4. **Unsupported partition key types**: For `HashPartitioning` and
`RangePartitioning`, native shuffle
+3. **Unsupported partition key types**: For `HashPartitioning` and
`RangePartitioning`, native shuffle
only supports primitive types as partition keys. Complex types (struct,
array, map) cannot be used
- as partition keys in native shuffle, though they are fully supported as
data columns in both implementations.
+ as partition keys in native shuffle and will fall back to JVM shuffle. Note
that complex types are
Review Comment:
```suggestion
as partition keys in native shuffle and will fall back to JVM columnar
shuffle. Note that complex types are
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
