AnjaliChoudhary99 opened a new pull request, #19862:
URL: https://github.com/apache/datafusion/pull/19862
- Merged CTE reference resolution tests into main cte.slt file
- Added CREATE TABLE statement for orders table used in tests
- Fixed 3 case-sensitivity issues: changed 'WHERE N < 10' to 'WHERE n < 10'
Fixes #19786
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #19786
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This PR consolidates the small test file `cte_quoted_reference.slt` into the
main `cte.slt` file as requested in issue #19786. The separate file was small
enough that it didn't need to be maintained independently, and consolidating it
improves code organization and maintainability.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Merged CTE reference resolution tests from `cte_quoted_reference.slt` into
`cte.slt`
- Added `CREATE TABLE orders AS VALUES (1), (2);` statement to support the
merged tests
- Fixed 3 pre-existing case-sensitivity bugs by changing `WHERE N < 10` to
`WHERE n < 10` in recursive CTE tests
- Deleted `cte_quoted_reference.slt` as it's now consolidated into the main
file
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, all changes are tested:
- The consolidated tests from `cte_quoted_reference.slt` are now part of the
`cte.slt` test suite
- All sqllogictest tests pass successfully: `cargo test --test sqllogictests
-- cte`
- The case-sensitivity fixes ensure that field references match their
definitions (lowercase `n`)
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No, there are no user-facing changes. This is purely a test file
reorganization that improves code maintainability without affecting
DataFusion's functionality or API.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
