milenkovicm commented on code in PR #1393: URL: https://github.com/apache/datafusion-ballista/pull/1393#discussion_r2705039093
########## docs/source/user-guide/extensions-example.md: ########## @@ -214,16 +214,60 @@ scheduler. The logical extension codec typically consists of two components: Google Protocol Buffer definitions: ```proto +syntax = "proto3"; + +package extension.ballista; + +// we do not use this in this example +// i'm leaving it as it might be important +// later Review Comment: we do use it in codecs, maybe just clarify that it will be translated to rust structures at the build time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
